Open
Conversation
rcosta358
added
error messages
CatarinaGamboa
requested changes
May 11, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
I think we should keep the ite grouped expressions, maybe the --> as well. They would pass the parser correctly but its harder for developers to easily see the right associative rule - at least for me it is, what do you think?
| assertEquals("(a ? b : c) ? d : e", | ||
| new Ite(new GroupExpression(ite), new Var("d"), new Var("e")).toDisplayString()); | ||
| assertEquals("a ? b : (c ? d : e)", | ||
| assertEquals("a ? b : c ? d : e", |
Collaborator
There was a problem hiding this comment.
in here I think we want the parenthesis to still be there, right? reading it, it could either be
a ? b : c ? d : e
a) a ? b : (c ? d : e)
b) (a ? b : c) ? d : e
Also we can improve the tree construction as well, but you can do that in a followup PR
Collaborator
Author
|
I think it's understandable without the parentheses but I get your point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
ExpressionFormatterso grouped expressions only have parentheses when needed for precedence or associativity. This simplifies expressions in the error messages and in the context debugger.Example
Before and after:
(1)→1(a > 0)→a > 0a && (b > 0)→a && b > 0Unchanged cases:
a - (b + c)x == (1 > 0)!(x > 0)Related Issue
None.
Type of change
Checklist
ExpressionFormatterTestmvn testpasses locally